Author lemburg
Recipients eric.araujo, lemburg, pitrou, r.david.murray, vstinner
Date 2010-08-13.10:35:50
SpamBayes Score 5.55988e-07
Marked as misclassified No
Message-id <4C652004.4020302@egenix.com>
In-reply-to <1281660823.72.0.353097212087.issue9560@psf.upfronthosting.co.za>
Content
Éric Araujo wrote:
> 
> Éric Araujo <merwok@netwok.org> added the comment:
> 
> Is it guaranteed that the -b option will be present in every version of file?

Looking at the only use case of _syscmd_file(), it may not even be worth
the trouble of adding the -b option. Fixing the doc-string may be enough:

    # Get data from the 'file' system command
    if executable:
        output = _syscmd_file(executable, '')
    else:
        output = ''

    ...

    # Split the output into a list of strings omitting the filename
    fileout = _architecture_split(output)[1:]

Note how architecture() already chops off the filename, so it
relies on the existing behavior, rather than the one described
in the doc-string of _syscmd_file().

Sorry, Victor, for not spotting this earlier on.
History
Date User Action Args
2010-08-13 10:35:53lemburgsetrecipients: + lemburg, pitrou, vstinner, eric.araujo, r.david.murray
2010-08-13 10:35:51lemburglinkissue9560 messages
2010-08-13 10:35:50lemburgcreate