Message113669
I think patch may be simplified. Instead of keeping track of CRC offset, invoke it directly on the 'data' variable being added to _readbuffer.
Also the call to _update_crc() before the return from read1() looks redundant.
Finally, is it possible to determine end of file if length of 'data' (computed for crc) is 0? |
|
Date |
User |
Action |
Args |
2010-08-12 09:15:27 | nirai | set | recipients:
+ nirai, pitrou, dougturk, BreamoreBoy |
2010-08-12 09:15:27 | nirai | set | messageid: <1281604527.11.0.833571850348.issue7467@psf.upfronthosting.co.za> |
2010-08-12 09:15:25 | nirai | link | issue7467 messages |
2010-08-12 09:15:25 | nirai | create | |
|