This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author denversc
Recipients benjamin.peterson, bethard, brian.curtin, denversc, eric.araujo, eric.smith, r.david.murray
Date 2010-08-11.23:32:10
SpamBayes Score 0.00017688348
Marked as misclassified No
Message-id <1281569533.28.0.945451296687.issue9553@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the input, r.david.murray.  I've updated my patch and attached it to take into consideration your comments: test_argparse.py.COLUMNS.update2.patch.  The updated patch uses EnviormentVarGuard as suggested, except that it slightly tweaks EnviormentVarGuard so the context manager protocol methods don't have to be invoked directly.

It was also pointed out that "adding setUp and tearDown to TestCase isn't enough, since subclasses and mixins define those without calling the superclass versions", which is true.  However, the tests that override setUp() happen to be those that don't depend on the COLUMNS environment variable.
History
Date User Action Args
2010-08-11 23:32:18denverscsetrecipients: + denversc, bethard, eric.smith, benjamin.peterson, eric.araujo, r.david.murray, brian.curtin
2010-08-11 23:32:13denverscsetmessageid: <1281569533.28.0.945451296687.issue9553@psf.upfronthosting.co.za>
2010-08-11 23:32:12denversclinkissue9553 messages
2010-08-11 23:32:11denversccreate