This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Walter.Woods
Recipients Walter.Woods, barry, dstanek, eric.araujo, hdiogenes, l0nwlf, orsenthil, r.david.murray
Date 2010-08-01.22:18:19
SpamBayes Score 0.017613918
Marked as misclassified No
Message-id <1280701101.45.0.505100258799.issue8572@psf.upfronthosting.co.za>
In-reply-to
Content
Hi David,

I like most of your patch (especially since it has unit tests), and if people like yourself are actually using the current functionality then that's fine, but one recommendation: why not change this line:

if not headers or isinstance(headers, str):

To also include the clause ``or getattr(headers, '__iter__', False)``.  That way, other default values (such as numbers) would work as expected rather than throw an error.  What do you think of that?
History
Date User Action Args
2010-08-01 22:18:21Walter.Woodssetrecipients: + Walter.Woods, barry, orsenthil, dstanek, hdiogenes, eric.araujo, r.david.murray, l0nwlf
2010-08-01 22:18:21Walter.Woodssetmessageid: <1280701101.45.0.505100258799.issue8572@psf.upfronthosting.co.za>
2010-08-01 22:18:19Walter.Woodslinkissue8572 messages
2010-08-01 22:18:19Walter.Woodscreate