Message112391
Hi David,
I like most of your patch (especially since it has unit tests), and if people like yourself are actually using the current functionality then that's fine, but one recommendation: why not change this line:
if not headers or isinstance(headers, str):
To also include the clause ``or getattr(headers, '__iter__', False)``. That way, other default values (such as numbers) would work as expected rather than throw an error. What do you think of that? |
|
Date |
User |
Action |
Args |
2010-08-01 22:18:21 | Walter.Woods | set | recipients:
+ Walter.Woods, barry, orsenthil, dstanek, hdiogenes, eric.araujo, r.david.murray, l0nwlf |
2010-08-01 22:18:21 | Walter.Woods | set | messageid: <1280701101.45.0.505100258799.issue8572@psf.upfronthosting.co.za> |
2010-08-01 22:18:19 | Walter.Woods | link | issue8572 messages |
2010-08-01 22:18:19 | Walter.Woods | create | |
|