Author vstinner
Recipients BreamoreBoy, alexandre.vassalotti, amaury.forgeotdarc, collinwinter, hagen, pitrou, vstinner
Date 2010-07-29.16:38:50
SpamBayes Score 0.00398338
Marked as misclassified No
Message-id <1280421532.17.0.222094686679.issue3873@psf.upfronthosting.co.za>
In-reply-to
Content
> Victor, have you tried using peek() instead of seek()? 
> I mentioned this previously in msg85780.

In a file encoded in protocol 0, backward seek are needed to each call to unpickler_readline... and this function is called to read a number, a boolean, etc. (to read most, or all, data values). I choosed to disable the read buffer because it's slower with it.

For protocol 1 and 2, there is only *one* seek at the end (but a lot of read: file size / 4096). So I don't think that it does really matter to use peek or seek.

seek() is more natural (for me) and frequent than peek(), so I prefer to keep seek().
History
Date User Action Args
2010-07-29 16:38:52vstinnersetrecipients: + vstinner, collinwinter, amaury.forgeotdarc, pitrou, alexandre.vassalotti, hagen, BreamoreBoy
2010-07-29 16:38:52vstinnersetmessageid: <1280421532.17.0.222094686679.issue3873@psf.upfronthosting.co.za>
2010-07-29 16:38:51vstinnerlinkissue3873 messages
2010-07-29 16:38:50vstinnercreate