Author alexandre.vassalotti
Recipients alexandre.vassalotti, belopolsky, collinwinter, pitrou, vstinner
Date 2010-07-29.06:25:42
SpamBayes Score 0.00344711
Marked as misclassified No
Message-id <1280384767.75.0.12386540434.issue9410@psf.upfronthosting.co.za>
In-reply-to
Content
This is a big patch. Please review at http://codereview.appspot.com/1694050/show

This patch adds the most interesting optimizations from Unladen Swallow to Python 3's pickle.

The core of the patch already been reviewed by Antoine and me (http://codereview.appspot.com/33070/show). One of the last issue remaining the unbounded size of the internal buffer. This shouldn't be a big issue for most uses of pickle, since the size of a  pickle is often several times smaller than the object hierarchy that created it. I still hope to fix this in a following patch.

The patch also include additional cleanups to the Pdata structure. The changes felt natural to make along with the other changes from Unladen Swallow. IIRC, these changes yield an additional 1-3% speedup.
History
Date User Action Args
2010-07-29 06:26:08alexandre.vassalottisetrecipients: + alexandre.vassalotti, collinwinter, belopolsky, pitrou, vstinner
2010-07-29 06:26:07alexandre.vassalottisetmessageid: <1280384767.75.0.12386540434.issue9410@psf.upfronthosting.co.za>
2010-07-29 06:26:04alexandre.vassalottilinkissue9410 messages
2010-07-29 06:26:03alexandre.vassalotticreate