Message111767
I am attaching a patch, issue9315-trace-fix.diff, that fixes a py3k bug exposed by issue9315.1-py3k.patch tests.
One of the 3.x changes that caused the failure was that frames now have a __doc__ attribute and cannot be distinguished from functions. I replaced the hasattr(f, "__doc__") with hasattr(f, "__annotations__"), but I wonder if it would be better to use something like isinstance(f, types.FunctionType) there.
Eli, in order to test the trace module more thoroughly, you need to add generators, list and set comprehensions and instance, class, and static methods to your fake module and test tracing of their execution. |
|
Date |
User |
Action |
Args |
2010-07-28 03:28:20 | belopolsky | set | recipients:
+ belopolsky, terry.reedy, eli.bendersky |
2010-07-28 03:28:20 | belopolsky | set | messageid: <1280287700.53.0.79849624902.issue9315@psf.upfronthosting.co.za> |
2010-07-28 03:28:18 | belopolsky | link | issue9315 messages |
2010-07-28 03:28:18 | belopolsky | create | |
|