Author eli.bendersky
Recipients eli.bendersky, eric.araujo, rhettinger, stutzbach
Date 2010-07-26.04:27:36
SpamBayes Score 0.000484867
Marked as misclassified No
Message-id <1280118469.15.0.492522805022.issue9214@psf.upfronthosting.co.za>
In-reply-to
Content
Hello,

I'm attaching a patch for this issue. 

1. _from_iterable in KeysView and ItemsView overridden as per Daniel's suggestion (Lib/_abcoll.py)
2. Added a test case to Lib/test/test_collections.py that uses this test case (creates the subclass and attempts modifying the view), with Raymond's suggestions incorporated, as well as a simple correctness test.

The patch was made against the latest dev checkout. If it's found sufficient, I can backport it to 2.6/2.7

---

P.S. The patch was generated from a Hg mirror, so to patch it -p1 is to be used. If this is a problem, let me know and I'll generate a patch from an SVN working directory. I got the impression from the #python-dev IRC channel that submitting patches from Hg is fine, but I may be wrong here.
History
Date User Action Args
2010-07-26 04:27:51eli.benderskysetrecipients: + eli.bendersky, rhettinger, stutzbach, eric.araujo
2010-07-26 04:27:49eli.benderskysetmessageid: <1280118469.15.0.492522805022.issue9214@psf.upfronthosting.co.za>
2010-07-26 04:27:47eli.benderskylinkissue9214 messages
2010-07-26 04:27:42eli.benderskycreate