Author mark.smith
Recipients docs@python, eric.araujo, ezio.melotti, georg.brandl, loewis, mark.smith, terry.reedy
Date 2010-07-25.09:04:55
SpamBayes Score 0.00361159
Marked as misclassified No
Message-id <1280048705.83.0.173875117089.issue7635@psf.upfronthosting.co.za>
In-reply-to
Content
Terry, thanks for the feedback!

I have added a patch, replacing the previous one, which deals with your points 1 and 3 in the following ways:

1. I have used (an edited form of) your synopsis - I've removed the details of exactly what is returned from the iterator, as I thought it made the sentence structure slightly awkward - hope you don't mind. I've moved the old synopsis to the heading, which is where I intended it to be anyway.

3. I added the newline - I don't think this is really a problem, but neither is the fix :)

Regarding point 2: I agree with you - I struggled with whether to include references to these classes, eventually settling for what you see. I suppose they could be re-used for converting SAX events to DOM nodes, so it could be useful to know they are there.

SAX2DOM isn't even used internally, so is technically part of the module's public interface, but with such brittle behaviour that I think it should really be removed. It automatically adds children to their parent when they are parsed -- but the children will only be parsed if the buffer is large enough. If it isn't then you can get incorrectly empty or even partial subtrees.
History
Date User Action Args
2010-07-25 09:05:07mark.smithsetrecipients: + mark.smith, loewis, georg.brandl, terry.reedy, ezio.melotti, eric.araujo, docs@python
2010-07-25 09:05:05mark.smithsetmessageid: <1280048705.83.0.173875117089.issue7635@psf.upfronthosting.co.za>
2010-07-25 09:05:03mark.smithlinkissue7635 messages
2010-07-25 09:05:02mark.smithcreate