This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients BreamoreBoy, akuchling, amaury.forgeotdarc, ffrederick
Date 2010-07-22.09:55:19
SpamBayes Score 0.0040472266
Marked as misclassified No
Message-id <1279792521.31.0.632000401168.issue1723038@psf.upfronthosting.co.za>
In-reply-to
Content
The patch should be amended for python3, then:
- PyType_Ready() should be used instead of "ob_type = &PyType_Type;"
- The demo contains "Option choisie :" which should be translated :-)
- the call::
     PyErr_SetString(PyExc_RuntimeError,
                     "remove_lom: can't find Menu Object");
  is wrong: the calling function does not check the error condition, it will be ignored in any case because the only called is the tp_dealloc
- find_po() is defined but never called
- the free() method does not do anything, it contains commented out code.

In short, this patch needs work.
History
Date User Action Args
2010-07-22 09:55:21amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, akuchling, ffrederick, BreamoreBoy
2010-07-22 09:55:21amaury.forgeotdarcsetmessageid: <1279792521.31.0.632000401168.issue1723038@psf.upfronthosting.co.za>
2010-07-22 09:55:19amaury.forgeotdarclinkissue1723038 messages
2010-07-22 09:55:19amaury.forgeotdarccreate