Message111158
The patch should be amended for python3, then:
- PyType_Ready() should be used instead of "ob_type = &PyType_Type;"
- The demo contains "Option choisie :" which should be translated :-)
- the call::
PyErr_SetString(PyExc_RuntimeError,
"remove_lom: can't find Menu Object");
is wrong: the calling function does not check the error condition, it will be ignored in any case because the only called is the tp_dealloc
- find_po() is defined but never called
- the free() method does not do anything, it contains commented out code.
In short, this patch needs work. |
|
Date |
User |
Action |
Args |
2010-07-22 09:55:21 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, akuchling, ffrederick, BreamoreBoy |
2010-07-22 09:55:21 | amaury.forgeotdarc | set | messageid: <1279792521.31.0.632000401168.issue1723038@psf.upfronthosting.co.za> |
2010-07-22 09:55:19 | amaury.forgeotdarc | link | issue1723038 messages |
2010-07-22 09:55:19 | amaury.forgeotdarc | create | |
|