This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author BreamoreBoy
Recipients BreamoreBoy, christian.heimes, gjb1002, rodolpho, stranger4good, werneck, zanella
Date 2010-07-18.11:09:44
SpamBayes Score 0.00011317135
Marked as misclassified No
Message-id <>
I applied the patch to only and all tests passed, surely that's not correct.

Removing the explicit test for a non-numeric port in seems strange to me, could someone please explain the rationale behind this.

I also noticed this line in the patch.

if self.debuglevel > 0: print>>stderr, "connect:", msg

And this comment in set_debuglevel in

"A non-false value results in debug messages for connection and for all
messages sent to and received from the server."

IIRC if a string was passed into set_debuglevel the comparison would fail in py3k, am I correct?  The print statement would not work in py3k.
Given that the debuglevel code obviously doesn't get tested perhaps it should simply be stripped from the code?
Date User Action Args
2010-07-18 11:09:48BreamoreBoysetrecipients: + BreamoreBoy, gjb1002, christian.heimes, stranger4good, zanella, werneck, rodolpho
2010-07-18 11:09:47BreamoreBoysetmessageid: <>
2010-07-18 11:09:45BreamoreBoylinkissue2118 messages
2010-07-18 11:09:44BreamoreBoycreate