Author brian.curtin
Recipients abbot, astrand, brian.curtin, dmalcolm, filippo, giampaolo.rodola, guettli, orsenthil, pitrou, r.david.murray, rnk, srid
Date 2010-07-14.16:54:50
SpamBayes Score 0.278151
Marked as misclassified No
Message-id <1279126496.44.0.963975102672.issue5673@psf.upfronthosting.co.za>
In-reply-to
Content
I'm looking into the TODO details right now, but the patch as-is didn't pass for me.

The last line of test_communicate_timeout fails on Windows 7 with "pineapple\r\npear\r\n" not matching "pineapple\npear\n". Creating the Popen object with universal_newlines=1 fixes the issue locally (haven't tried on other OSes), but it should probably follow the convention laid out in test_universal_newlines.
History
Date User Action Args
2010-07-14 16:54:56brian.curtinsetrecipients: + brian.curtin, guettli, astrand, orsenthil, pitrou, giampaolo.rodola, abbot, r.david.murray, rnk, srid, dmalcolm, filippo
2010-07-14 16:54:56brian.curtinsetmessageid: <1279126496.44.0.963975102672.issue5673@psf.upfronthosting.co.za>
2010-07-14 16:54:50brian.curtinlinkissue5673 messages
2010-07-14 16:54:50brian.curtincreate