Author pitrou
Recipients Christophe Simonis, ajaksu2, andybuckley, brian.curtin, christian.heimes, edemaine, eric.araujo, iki, meatballhat, michael.foord, pitrou, tarek, tleeuwenburg@gmail.com
Date 2010-07-12.11:47:12
SpamBayes Score 0.00120943
Marked as misclassified No
Message-id <1278935234.53.0.867571365335.issue444582@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments on the patch:
- shouldn't getdir_id use os.path.normcase() rather than manually switch on `windows`?
- the patch adds lots of names at the top-level which aren't part of the public API ("windows", "getdir_id", "defpath", "defpath_ext"). They should probably start with an underscore.
- if PATH is updated after shutil is first imported, the changes won't get picked up. Is it desired?
History
Date User Action Args
2010-07-12 11:47:14pitrousetrecipients: + pitrou, edemaine, christian.heimes, ajaksu2, tarek, eric.araujo, Christophe Simonis, andybuckley, tleeuwenburg@gmail.com, michael.foord, brian.curtin, meatballhat, iki
2010-07-12 11:47:14pitrousetmessageid: <1278935234.53.0.867571365335.issue444582@psf.upfronthosting.co.za>
2010-07-12 11:47:12pitroulinkissue444582 messages
2010-07-12 11:47:12pitroucreate