Author rnk
Recipients BreamoreBoy, rnk, ronaldoussoren
Date 2010-07-11.12:38:59
SpamBayes Score 0.16923
Marked as misclassified No
Message-id <1278851946.66.0.978998221515.issue7576@psf.upfronthosting.co.za>
In-reply-to
Content
This patch looks good to me, after digging through the relevant module code.

I was confused though for a bit as to why PyModuleDef is a PyObject with a NULL type.  It turns out that import.c wants to keep them in a dictionary, so it needs to be able to cast to PyObject* and to access the refcount.  It never needs the type, though, so it's safe to leave it NULL.  I think it might be worth adding comments explaining that in this patch or another.
History
Date User Action Args
2010-07-11 12:39:06rnksetrecipients: + rnk, ronaldoussoren, BreamoreBoy
2010-07-11 12:39:06rnksetmessageid: <1278851946.66.0.978998221515.issue7576@psf.upfronthosting.co.za>
2010-07-11 12:39:00rnklinkissue7576 messages
2010-07-11 12:38:59rnkcreate