Author pitrou
Recipients gregory.p.smith, hobb0001, jyasskin, pitrou, rnk
Date 2010-07-10.16:13:52
SpamBayes Score 0.00882568
Marked as misclassified No
Message-id <1278778441.87.0.455388183261.issue8844@psf.upfronthosting.co.za>
In-reply-to
Content
Oh, nice!

> I was wondering if I should merge PyThread_acquire_lock_timed with my
> new PyThread_acquire_lock_timed_intr, since PyThread_acquire_lock_timed 
> wasn't available in 3.1.

Yes, I think you should.

I haven't tried the patch, but it seems you got the logic right. There's a problem sometimes that you're using 2 spaces for indent rather than 4. Also, you forgot to update the RLock implementation in _threadmodule.c (and perhaps add another test for it).

(there are other modules which use the PyThread_acquire_lock API, but most of the time the locks are held for a short time (and shouldn't deadlock), which makes converting them less of a priority)
History
Date User Action Args
2010-07-10 16:14:01pitrousetrecipients: + pitrou, gregory.p.smith, jyasskin, rnk, hobb0001
2010-07-10 16:14:01pitrousetmessageid: <1278778441.87.0.455388183261.issue8844@psf.upfronthosting.co.za>
2010-07-10 16:13:52pitroulinkissue8844 messages
2010-07-10 16:13:52pitroucreate