Message109884
Oh, nice!
> I was wondering if I should merge PyThread_acquire_lock_timed with my
> new PyThread_acquire_lock_timed_intr, since PyThread_acquire_lock_timed
> wasn't available in 3.1.
Yes, I think you should.
I haven't tried the patch, but it seems you got the logic right. There's a problem sometimes that you're using 2 spaces for indent rather than 4. Also, you forgot to update the RLock implementation in _threadmodule.c (and perhaps add another test for it).
(there are other modules which use the PyThread_acquire_lock API, but most of the time the locks are held for a short time (and shouldn't deadlock), which makes converting them less of a priority) |
|
Date |
User |
Action |
Args |
2010-07-10 16:14:01 | pitrou | set | recipients:
+ pitrou, gregory.p.smith, jyasskin, rnk, hobb0001 |
2010-07-10 16:14:01 | pitrou | set | messageid: <1278778441.87.0.455388183261.issue8844@psf.upfronthosting.co.za> |
2010-07-10 16:13:52 | pitrou | link | issue8844 messages |
2010-07-10 16:13:52 | pitrou | create | |
|