Message109664
> If the attributes were of the "__private" kind, they weren't meant to
> be used by other classes, and so there's no problem in making them
> public.
Generally I would agree with you but this case is different, imho.
The problem here is that those items didn't have to be declared "__private" in the first place. As a consequence of this I think it's reasonable to expect that during the years some code out there might got to rely on them by using name-mangling hack.
After all smtpd module is very old and SMTPHandler class likely to be subclassed because of its basic implementation, and that is why I see some similarities with issue 8483.
I was of the opinion that just removing the __getattr___ ugliness without passing through the usual DeprecationWarning period supposed to be applied in such circumstances would cause no harm, until I realized I was relying on that very functionality in pyftpdlib and I didn't even know it. |
|
Date |
User |
Action |
Args |
2010-07-09 01:58:48 | giampaolo.rodola | set | recipients:
+ giampaolo.rodola, richard, pitrou, doughellmann, BreamoreBoy |
2010-07-09 01:58:48 | giampaolo.rodola | set | messageid: <1278640728.29.0.864812619252.issue4184@psf.upfronthosting.co.za> |
2010-07-09 01:58:46 | giampaolo.rodola | link | issue4184 messages |
2010-07-09 01:58:45 | giampaolo.rodola | create | |
|