Author giampaolo.rodola
Recipients BreamoreBoy, doughellmann, giampaolo.rodola, richard
Date 2010-07-08.19:47:22
SpamBayes Score 0.00113589
Marked as misclassified No
Message-id <1278618444.69.0.699488300255.issue4184@psf.upfronthosting.co.za>
In-reply-to
Content
The patch as-is can't be accepted if not for Python 4.x maybe, obviously because it's just too breaking.

A proper patch would provide aliases for the removed attributes and raise a DeprecationWarning in case they are accessed.
It would be suitable for the the next major release (3.2 at the current time) and the total removal of the deprecated attributes would happen only in 3.3 if not later.

Also, I see no reason in turning public attributes like self.__line,  self.__state and self.__greeting.
They should just be private (one underscore) and their name kept the same (e.g. no __server -> smtp_server, __greeting -> seen_greting, etc...).

Finally, tests should definitively be written.
History
Date User Action Args
2010-07-08 19:47:24giampaolo.rodolasetrecipients: + giampaolo.rodola, richard, doughellmann, BreamoreBoy
2010-07-08 19:47:24giampaolo.rodolasetmessageid: <1278618444.69.0.699488300255.issue4184@psf.upfronthosting.co.za>
2010-07-08 19:47:23giampaolo.rodolalinkissue4184 messages
2010-07-08 19:47:22giampaolo.rodolacreate