Author terry.reedy
Recipients LambertDW, eli.bendersky, georg.brandl, ggenellina, gjb1002, hagna, janpf, jimjjewett, mrotondo, pitrou, r.david.murray, rtvd, sjmachin, terry.reedy, tim.peters, vbr
Date 2010-06-28.19:35:36
SpamBayes Score 1.42943e-05
Marked as misclassified No
Message-id <1277753738.67.0.335360077661.issue2986@psf.upfronthosting.co.za>
In-reply-to
Content
The discussion on #152807 references two other closed tracker issues:
#1678339 Test case that currently fails
#1678345 Patch to change behavior - rejected because crippled behavior is supposedly intentional and removing the change would slow things down.

The patch simply removes the internal heuristic. I think a better patch would be to make it optional, with a tunable popularity threshold.

I say 'supposedly intentional' because the code comments only justify the popularity hack for code line comparison and give no indication of awareness that it disables SequenceMatcher for general purpose use, and in particular, for non-toy finite character set comparisons of the type (ascii) used in all the examples.
History
Date User Action Args
2010-06-28 19:35:40terry.reedysetrecipients: + terry.reedy, tim.peters, georg.brandl, jimjjewett, sjmachin, gjb1002, ggenellina, pitrou, rtvd, vbr, LambertDW, hagna, r.david.murray, eli.bendersky, janpf, mrotondo
2010-06-28 19:35:38terry.reedysetmessageid: <1277753738.67.0.335360077661.issue2986@psf.upfronthosting.co.za>
2010-06-28 19:35:37terry.reedylinkissue2986 messages
2010-06-28 19:35:36terry.reedycreate