Message108186
On the principle the patch looks good. In practice, it lacks a call to `PyBuffer_Release(&buffer)` in the various error cases (before returning NULL). It also lacks some tests in Lib/test/test_array.py.
> In 3.x unicode type was renamed to str and str to bytes, so fromunicode
> should become fromstring (or maybe fromstr to avoid confusion) and
> fromstring should become frombytes.
This should be discussed separately, perhaps on python-dev first. |
|
Date |
User |
Action |
Args |
2010-06-19 15:24:11 | pitrou | set | recipients:
+ pitrou, terry.reedy, belopolsky, vstinner, tjollans |
2010-06-19 15:24:10 | pitrou | set | messageid: <1276961050.88.0.917548125508.issue8990@psf.upfronthosting.co.za> |
2010-06-19 15:24:09 | pitrou | link | issue8990 messages |
2010-06-19 15:24:08 | pitrou | create | |
|