Author pitrou
Recipients belopolsky, pitrou, terry.reedy, tjollans, vstinner
Date 2010-06-19.15:24:08
SpamBayes Score 9.03789e-05
Marked as misclassified No
Message-id <1276961050.88.0.917548125508.issue8990@psf.upfronthosting.co.za>
In-reply-to
Content
On the principle the patch looks good. In practice, it lacks a call to `PyBuffer_Release(&buffer)` in the various error cases (before returning NULL). It also lacks some tests in Lib/test/test_array.py.

> In 3.x unicode type was renamed to str and str to bytes, so fromunicode 
> should become fromstring (or maybe fromstr to avoid confusion) and
> fromstring should become frombytes.

This should be discussed separately, perhaps on python-dev first.
History
Date User Action Args
2010-06-19 15:24:11pitrousetrecipients: + pitrou, terry.reedy, belopolsky, vstinner, tjollans
2010-06-19 15:24:10pitrousetmessageid: <1276961050.88.0.917548125508.issue8990@psf.upfronthosting.co.za>
2010-06-19 15:24:09pitroulinkissue8990 messages
2010-06-19 15:24:08pitroucreate