Author mark.dickinson
Recipients abrown, belopolsky, brett.cannon, dmhouse, dudologist, eka, eric.araujo, mark.dickinson
Date 2010-06-17.16:40:47
SpamBayes Score 0.00425784
Marked as misclassified No
Message-id <1276792850.34.0.371778124175.issue6641@psf.upfronthosting.co.za>
In-reply-to
Content
Doc nit: "When ``%z`` directive" -> "When the ``%z`` directive"

The _strptime._strptime docstring is inaccurate:  it claim to return a time struct, but actually returns tuple, int;  please could you also add docstrings for _strptime_time and _strptime_datetime?

Spacing in datetimemodule.c:  "if( module == NULL)" -> "if (module == NULL)".  Also, is there any particular reason for initializing 'result' to NULL?  (Or even for using result at all;  you could just do "return PyObject_CallMethod(... ").

I'm mildly distressed by the inability of strptime to parse UTC offsets in the +HH:MM form that str(timezone) produces, but I'm not sure what the solution to that is.

Otherwise, this all looks good to my non-expert eye.
History
Date User Action Args
2010-06-17 16:40:51mark.dickinsonsetrecipients: + mark.dickinson, brett.cannon, belopolsky, eric.araujo, eka, dmhouse, abrown, dudologist
2010-06-17 16:40:50mark.dickinsonsetmessageid: <1276792850.34.0.371778124175.issue6641@psf.upfronthosting.co.za>
2010-06-17 16:40:48mark.dickinsonlinkissue6641 messages
2010-06-17 16:40:47mark.dickinsoncreate