Author r.david.murray
Recipients brian.curtin, eric.smith, exarkun, ezio.melotti, gregory.p.smith, r.david.murray, shypike
Date 2010-06-14.01:55:20
SpamBayes Score 0.00186191
Marked as misclassified No
Message-id <1276480523.5.0.651969137738.issue8972@psf.upfronthosting.co.za>
In-reply-to
Content
The actual bug here is that list2cmdline is called when shell=True and a list is passed.  This should not be done.  Instead, Popen should raise an TypeError (see issue 7839).

When calling Popen with shell=True, you should be passing in a string that is already correctly quoted.  This is how it works in Unix, and is how it should work in Windows as well.

So I agree with exarkun's comments in msg107679, and I think Gregory's fix in r60115 for issue 1300 was incorrect and that in fact the OP was correct that he did not understand what was happening (note that he did not report an actual bug, he just reported that the code looked wrong to him).
History
Date User Action Args
2010-06-14 01:55:23r.david.murraysetrecipients: + r.david.murray, gregory.p.smith, exarkun, eric.smith, ezio.melotti, brian.curtin, shypike
2010-06-14 01:55:23r.david.murraysetmessageid: <1276480523.5.0.651969137738.issue8972@psf.upfronthosting.co.za>
2010-06-14 01:55:21r.david.murraylinkissue8972 messages
2010-06-14 01:55:20r.david.murraycreate