This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author samtygier
Recipients samtygier, tarek
Date 2010-06-02.14:36:20
SpamBayes Score 0.07806704
Marked as misclassified No
Message-id <1275489382.98.0.798193175281.issue8876@psf.upfronthosting.co.za>
In-reply-to
Content
here is a patch against http://svn.python.org/projects/python/trunk

it moves the return statements into the individual file copying sections, and takes the final call to _copy_file_contents() out of the else. this allows an error in hardlinking to fall through by passing the exception.

i have only tested on Linux.

when running it still prints out
"hard linking CHANGES -> pyzgoubi-0.4dev"
because of how the message is generated in line 130. do you think this needs to be changed. do we need a
"hardlinking failed, falling back to copy"
message? it might cause unnecessary worry (distutils already suppresses tracebacks to avoid scaring non-python-programmers).

i have a patch that applies to 2.6 as well, is there much chance of that being accepted?
History
Date User Action Args
2010-06-02 14:36:23samtygiersetrecipients: + samtygier, tarek
2010-06-02 14:36:22samtygiersetmessageid: <1275489382.98.0.798193175281.issue8876@psf.upfronthosting.co.za>
2010-06-02 14:36:21samtygierlinkissue8876 messages
2010-06-02 14:36:21samtygiercreate