Message 105682 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	stutzbach
Recipients	belopolsky, draghuram, mark.dickinson, rhettinger, stutzbach
Date	2010-05-14.03:55:56
SpamBayes Score	6.296118e-05
Marked as misclassified	No
Message-id	<1273809360.08.0.161650749664.issue8692@psf.upfronthosting.co.za>
In-reply-to

Content
Attached is a patch to improve the unit tests for the factorial function. To compute the check value, it keeps a running total instead of recomputing the factorial from scratch inside the loop. It checks up to range(999) and is quite fast. The previous code checked range(10). It also adds the following checks: * 0! == 1 * (sys.maxsize+1)! => OverflowError * 10e100 => OverflowError

Attached is a patch to improve the unit tests for the factorial function.

To compute the check value, it keeps a running total instead of recomputing the factorial from scratch inside the loop.  It checks up to range(999) and is quite fast.  The previous code checked range(10).

It also adds the following checks:
 * 0! == 1
 * (sys.maxsize+1)! => OverflowError
 * 10e100 => OverflowError

History
Date	User	Action	Args
2010-05-14 03:56:00	stutzbach	set	recipients: + stutzbach, rhettinger, mark.dickinson, belopolsky, draghuram
2010-05-14 03:56:00	stutzbach	set	messageid: <1273809360.08.0.161650749664.issue8692@psf.upfronthosting.co.za>
2010-05-14 03:55:58	stutzbach	link	issue8692 messages
2010-05-14 03:55:57	stutzbach	create