Author eric.araujo
Recipients belopolsky, eric.araujo, ezio.melotti, giampaolo.rodola, pitrou, stuaxo, tarek
Date 2010-05-09.19:35:33
SpamBayes Score 3.49655e-06
Marked as misclassified No
Message-id <4BE70E83.2050309@netwok.org>
In-reply-to <1273433145.21.0.463298069236.issue4972@psf.upfronthosting.co.za>
Content
Re-reading the patch, I notice it’s in the test module, not on the FTP
class, so I guess it’s perfectly fine. Is the string returned by a real
FTP server “331 username ok”? (My point is that I think it would be
better to have different strings for cmd_noop and cmd_user.)

I meant code outside the standard library. I thought this was in ftplib,
but since it’s in test_ftplib we don’t have to fear breaking other
people’s code.

In summary, the diff for ftplib seems good to me, with a minor remark
about the docstrings, and I don’t feel confident enough to give a review
about the tests.
History
Date User Action Args
2010-05-09 19:35:35eric.araujosetrecipients: + eric.araujo, belopolsky, pitrou, giampaolo.rodola, tarek, ezio.melotti, stuaxo
2010-05-09 19:35:33eric.araujolinkissue4972 messages
2010-05-09 19:35:33eric.araujocreate