Author mark.dickinson
Recipients akitada, belopolsky, christian.heimes, josm, loewis, mark.dickinson, rhettinger, robertwb, zanella
Date 2010-05-06.07:59:12
SpamBayes Score 0.00117026
Marked as misclassified No
Message-id <1273132755.65.0.194717237899.issue1533@psf.upfronthosting.co.za>
In-reply-to
Content
> I've never done a maintenance branch backport, but here is my attempt:
[...]

Yes, that sounds about right.  But after all that, you'll still need to modify the patch somewhat, since the requirements are different for 2.6:  floats should give a DeprecationWarning rather than a TypeError.  I think that's a straightforward change for Python/bltinmodule.c.  The trickier bit is coming up with tests that work properly---i.e., check that the appropriate warnings are produced, *and* that the the appropriate values are returned.  Look into the 'catch_warnings' function in the warnings module; (there's also 'check_warnings' in test_support, but I think that doesn't exist in 2.6).

'make patchcheck' only checks Python files and ReST files, as far as I can tell.

[I got your off-tracker emails;  will respond anon.]
History
Date User Action Args
2010-05-06 07:59:15mark.dickinsonsetrecipients: + mark.dickinson, loewis, rhettinger, belopolsky, christian.heimes, josm, robertwb, zanella, akitada
2010-05-06 07:59:15mark.dickinsonsetmessageid: <1273132755.65.0.194717237899.issue1533@psf.upfronthosting.co.za>
2010-05-06 07:59:13mark.dickinsonlinkissue1533 messages
2010-05-06 07:59:12mark.dickinsoncreate