This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author tseaver
Recipients andyk, gregory.p.smith, jjlee, orsenthil, tseaver
Date 2010-05-02.20:37:33
SpamBayes Score 4.2965482e-07
Marked as misclassified No
Message-id <1272832656.28.0.44890849306.issue3704@psf.upfronthosting.co.za>
In-reply-to
Content
I can confirm that the patch applies cleanly to the release26-maint
branch, and that the updated test fails without the updated
implementation.

However, the entire approach seems wrong to me:  the patched method
has just called 'request_path', which already cracked the URL using
urlparse.urlparse and put it back together again with
urlparse.urlunparse.

A better fix would be either to call urlparse.urlparse directly, or
else to add an argument to 'request_path' which kept it from doing the
unwanted reassembly.

Attaching a patch which implements the latter strategy.  Greg's new
test passes with this patch applied in place of the part of his patch
which touches Lib/cookielib.py.
History
Date User Action Args
2010-05-02 20:37:36tseaversetrecipients: + tseaver, gregory.p.smith, jjlee, orsenthil, andyk
2010-05-02 20:37:36tseaversetmessageid: <1272832656.28.0.44890849306.issue3704@psf.upfronthosting.co.za>
2010-05-02 20:37:34tseaverlinkissue3704 messages
2010-05-02 20:37:33tseavercreate