This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jafo
Recipients eric.smith, jafo, pitrou
Date 2010-05-01.22:40:21
SpamBayes Score 0.006007886
Marked as misclassified No
Message-id <1272753626.59.0.186090829944.issue8214@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the review Jack.

I was very tempted to split it into C and Python components, but I decided
against it because it's so close to the 2.7 release.  I think it would be
best to defer that for the Python 3 release, because of potential packaging
issues.  I'm open to discussion on that though.

I've changed all the return(NULL)s in the package.

NULL check on saved_hook is done.

I also had the same thought about the saved_hook/syslog ordering, so I've
changed it.

I've added soe unit tests.  I tried getting fancy and testing the exception
handling, but had to fork to do it and then unittests were still catching
the exception, so I just left it the minimal set of tests I put in there.

Thanks.
History
Date User Action Args
2010-05-01 22:40:27jafosetrecipients: + jafo, pitrou, eric.smith
2010-05-01 22:40:26jafosetmessageid: <1272753626.59.0.186090829944.issue8214@psf.upfronthosting.co.za>
2010-05-01 22:40:25jafolinkissue8214 messages
2010-05-01 22:40:24jafocreate