This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jafo
Recipients eric.smith, jafo
Date 2010-05-01.20:19:07
SpamBayes Score 8.691555e-05
Marked as misclassified No
Message-id <1272745149.49.0.973776556536.issue8214@psf.upfronthosting.co.za>
In-reply-to
Content
Jack Diederich commented:

I don't have my tracker login on this computer so I'll post here.
I'd +1 on making the module python with just the core functionality
imported from C (it releases the GIL when doing IO).  Then you
could replace the few hundred lines of C with just the few lines of
python from the prototype.  That said...    The parens in "return
(NULL)" are extra and against PEP 7 (though there are already a
bunch in syslogmodule.c).    You need to NULL check the saved_hook
in newhookobject() before INCREF'ing it.    Should the saved hook
be called after the syslog call?  It might do anything.    The
patch needs unit tests.
History
Date User Action Args
2010-05-01 20:19:09jafosetrecipients: + jafo, eric.smith
2010-05-01 20:19:09jafosetmessageid: <1272745149.49.0.973776556536.issue8214@psf.upfronthosting.co.za>
2010-05-01 20:19:07jafolinkissue8214 messages
2010-05-01 20:19:07jafocreate