Message104746
Jack Diederich commented:
I don't have my tracker login on this computer so I'll post here.
I'd +1 on making the module python with just the core functionality
imported from C (it releases the GIL when doing IO). Then you
could replace the few hundred lines of C with just the few lines of
python from the prototype. That said... The parens in "return
(NULL)" are extra and against PEP 7 (though there are already a
bunch in syslogmodule.c). You need to NULL check the saved_hook
in newhookobject() before INCREF'ing it. Should the saved hook
be called after the syslog call? It might do anything. The
patch needs unit tests. |
|
Date |
User |
Action |
Args |
2010-05-01 20:19:09 | jafo | set | recipients:
+ jafo, eric.smith |
2010-05-01 20:19:09 | jafo | set | messageid: <1272745149.49.0.973776556536.issue8214@psf.upfronthosting.co.za> |
2010-05-01 20:19:07 | jafo | link | issue8214 messages |
2010-05-01 20:19:07 | jafo | create | |
|