Author giampaolo.rodola
Recipients akuchling, djarb, facundobatista, forest, giampaolo.rodola, gvanrossum, intgr, j1m, jafo, josiahcarlson, kevinwatters, markb, mcdonc, pitrou, r.david.murray, stutzbach, tseaver
Date 2010-04-29.22:29:35
SpamBayes Score 2.14136e-06
Marked as misclassified No
Message-id <1272580177.29.0.656981550817.issue1641@psf.upfronthosting.co.za>
In-reply-to
Content
Assuming this is still desirable I'd really like to move forward with this issue.
The current situation is that we have two patches.

My patch
========

pros: 
 * affects asyncore.py only
 * (imho) cleaner, as it just adds one class
 * stable, as it has been used in pyftpdlib for over 3 years now

cons:
 * significantly slower compared to Josiah's "paired-heap" approach 


Josiah's patch
==============

pros:
 * significantly faster

cons:
 * affects asyncore.py and sched.py
 * sched.py is modified quite heavily, also it's not clear whether that has been done in a fully retro-compatible way or not, so a full review from someone who has experience with this module would be needed
 * it seems that sched.py gains brand new functionnalities which are not necessarily related with asyncore, hence tests and documentation should be added. Furthermore, belonging them to sched.py, maybe they should be treated in a separate issue


Both patches should no longer apply cleanly so they should be adjusted a little and the missing parts (full tests, documentation including example usage, etc...) completed.
It seems we both agree on the API, which is both simple and has the extra advantage of being the same as Twisted's.
Now it's only a matter of deciding what to do about the internal implementation.
History
Date User Action Args
2010-04-29 22:29:37giampaolo.rodolasetrecipients: + giampaolo.rodola, gvanrossum, akuchling, facundobatista, jafo, josiahcarlson, tseaver, pitrou, forest, kevinwatters, djarb, stutzbach, markb, r.david.murray, intgr, mcdonc, j1m
2010-04-29 22:29:37giampaolo.rodolasetmessageid: <1272580177.29.0.656981550817.issue1641@psf.upfronthosting.co.za>
2010-04-29 22:29:35giampaolo.rodolalinkissue1641 messages
2010-04-29 22:29:35giampaolo.rodolacreate