Author tseaver
Recipients benjamin.peterson, ferringb, georg.brandl, nnorwitz, rhettinger, schmir, tseaver
Date 2010-04-28.22:13:24
SpamBayes Score 4.30821e-10
Marked as misclassified No
Message-id <1272492807.85.0.475510899389.issue1574217@psf.upfronthosting.co.za>
In-reply-to
Content
I can confirm that the patch applies cleanly to the 2.6 branch, that the new test fails before rebuilding, and that the test passes afterwards:

 $ hg summary
 parent: 41597:295c02a21979 tip
  [svn r80597] Merged revisions 80596 via svnmerge from
 branch: release26-maint
 commit: (clean)
 update: (current)
 $ ./configure && make
 ...
 $ ./python -E -tt Lib/test/regrtest.py test_isinstance
 test_isinstance
 1 test OK.
 $ patch -p1 < /tmp/issue1574217_dont_mask_errors.patch
 patching file Lib/test/test_isinstance.py
 patching file Objects/abstract.c
 Hunk #1 succeeded at 2854 (offset 619 lines).
 Hunk #2 succeeded at 2878 (offset 600 lines).
 test_isinstance
 test test_isinstance failed -- Traceback (most recent call last):
   File "/home/tseaver/projects/hg-repo/issue1574217/Lib/test/test_isinstance.py", line 94, in test_isinstance_dont_mask_non_attribute_error
    self.assertRaises(RuntimeError, isinstance, c, bool)
 AssertionError: RuntimeError not raised
 
 1 test failed:
     test_isinstance
 $ make
 ...
 $ ./python -E -tt Lib/test/regrtest.py test_isinstance
 test_isinstance
 1 test OK.
History
Date User Action Args
2010-04-28 22:13:29tseaversetrecipients: + tseaver, nnorwitz, georg.brandl, rhettinger, ferringb, schmir, benjamin.peterson
2010-04-28 22:13:27tseaversetmessageid: <1272492807.85.0.475510899389.issue1574217@psf.upfronthosting.co.za>
2010-04-28 22:13:26tseaverlinkissue1574217 messages
2010-04-28 22:13:24tseavercreate