This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients giampaolo.rodola, josiah.carlson, josiahcarlson, michael.foord, pitrou, r.david.murray
Date 2010-04-22.10:48:16
SpamBayes Score 6.5671446e-07
Marked as misclassified No
Message-id <1271933299.94.0.905413766683.issue8490@psf.upfronthosting.co.za>
In-reply-to
Content
Some remarks:
- I agree with RDM's comment regarding inheritance
- you don't use use_poll in loop_waiting_for_flag()
- calling time.sleep() in loop_waiting_for_flag() looks wrong to me
- test_handle_error should check that the exception state is the expected one (ZeroDivisionError), if at all possible
- in test_set_reuse_addr, if SO_REUSEADDR fails I would suggest skipping the test with self.skip(...), rather than passing silently
- in test_set_reuse_addr, sock.close() rather than sock.close
- does asyncore support IPv6? test_create_socket checks only AF_INET
- do you plan to also test UDP? :)
History
Date User Action Args
2010-04-22 10:48:20pitrousetrecipients: + pitrou, josiahcarlson, giampaolo.rodola, josiah.carlson, r.david.murray, michael.foord
2010-04-22 10:48:19pitrousetmessageid: <1271933299.94.0.905413766683.issue8490@psf.upfronthosting.co.za>
2010-04-22 10:48:18pitroulinkissue8490 messages
2010-04-22 10:48:16pitroucreate