Author mark.dickinson
Recipients akuchling, asmodai, mark.dickinson, r.david.murray, skrah
Date 2010-04-21.13:08:48
SpamBayes Score 2.13902e-11
Marked as misclassified No
Message-id <1271855329.99.0.578757228759.issue7384@psf.upfronthosting.co.za>
In-reply-to
Content
This patch looks good to me, assuming that the buildbots are happy.  I agree that this seems like a sensible solution for now, even if it means limiting users to ncurses rather than ncursesw.

I was initially a bit surprised that it works on OS X, since OS X doesn't have 'ldd';  but in that case the os.system call simply outputs "sh: ldd: command not found" to stderr and (presumably) nothing to stdout;  no Python exception is raised, so it's all okay.  It might be worth adding code to avoid the os.system('ldd ...') call on OS X, just to avoid the unnecessary error message on the console.  Apart from this, I say +1 to applying the patch.

Many thanks for all the detective work!
History
Date User Action Args
2010-04-21 13:08:50mark.dickinsonsetrecipients: + mark.dickinson, akuchling, asmodai, r.david.murray, skrah
2010-04-21 13:08:49mark.dickinsonsetmessageid: <1271855329.99.0.578757228759.issue7384@psf.upfronthosting.co.za>
2010-04-21 13:08:48mark.dickinsonlinkissue7384 messages
2010-04-21 13:08:48mark.dickinsoncreate