Message103801
Thanks for the patch! One concern I have is that adding --help-options by default has the potential to break existing code, e.g. if someone using optparse or argparse was already defining their own --help-options flag. The backward compatible solution is to have --help-options disabled by default, and ask people to enable it with add_interface=True.
Comments on the argparse patch: I think it's probably overkill to create InterfaceFormatter - just do the appropriate formatting in the _InterfaceAction. I also wouldn't add format_interface or print_interface until someone requests them. Last nit: don't add the takes_value method, just inline your "self.nargs != 0" check in the one place you need it. |
|
Date |
User |
Action |
Args |
2010-04-21 04:19:45 | bethard | set | recipients:
+ bethard, wplappert, andybuckley, r.david.murray, gruszczy |
2010-04-21 04:19:43 | bethard | set | messageid: <1271823583.88.0.529351971156.issue4256@psf.upfronthosting.co.za> |
2010-04-21 04:19:40 | bethard | link | issue4256 messages |
2010-04-21 04:19:39 | bethard | create | |
|