Author bethard
Recipients andybuckley, bethard, gruszczy, r.david.murray, wplappert
Date 2010-04-21.04:19:39
SpamBayes Score 2.59357e-06
Marked as misclassified No
Message-id <1271823583.88.0.529351971156.issue4256@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch! One concern I have is that adding --help-options by default has the potential to break existing code, e.g. if someone using optparse or argparse was already defining their own --help-options flag. The backward compatible solution is to have --help-options disabled by default, and ask people to enable it with add_interface=True.

Comments on the argparse patch: I think it's probably overkill to create InterfaceFormatter - just do the appropriate formatting in the _InterfaceAction. I also wouldn't add format_interface or print_interface until someone requests them. Last nit: don't add the takes_value method, just inline your "self.nargs != 0" check in the one place you need it.
History
Date User Action Args
2010-04-21 04:19:45bethardsetrecipients: + bethard, wplappert, andybuckley, r.david.murray, gruszczy
2010-04-21 04:19:43bethardsetmessageid: <1271823583.88.0.529351971156.issue4256@psf.upfronthosting.co.za>
2010-04-21 04:19:40bethardlinkissue4256 messages
2010-04-21 04:19:39bethardcreate