This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients pitrou, vstinner
Date 2010-04-20.23:45:38
SpamBayes Score 1.3647289e-06
Marked as misclassified No
Message-id <1271807139.9.0.378140861036.issue8477@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments:
- your ssl_convert_filename() function has a strange signature
- using PyByteArray_AsString() is wrong, we release the GIL later and the buffer could be reallocated, leading to a crash; the right approach is to use PyObject_GetBuffer() and later PyBuffer_Release()
- as such, your function could simply return the bytes/bytearray PyObject *, and not fill the char * pointer
- adding tests for both the bytes and unicode cases would be nice
History
Date User Action Args
2010-04-20 23:45:40pitrousetrecipients: + pitrou, vstinner
2010-04-20 23:45:39pitrousetmessageid: <1271807139.9.0.378140861036.issue8477@psf.upfronthosting.co.za>
2010-04-20 23:45:38pitroulinkissue8477 messages
2010-04-20 23:45:38pitroucreate