Author Alexander.Belopolsky
Recipients Alexander.Belopolsky, ajaksu2, alanvgreen, amaury.forgeotdarc, guettli, josh-sf, sonderblade, tiktuk
Date 2010-04-20.16:02:17
SpamBayes Score 1.26332e-05
Marked as misclassified No
Message-id <1271779339.37.0.603568725323.issue1100942@psf.upfronthosting.co.za>
In-reply-to
Content
I am +1 for adding these features and I have only one comment on the code:

It is documented in time.strptime() documentation that
"""
The default values used to fill in any missing data when more accurate values cannot be inferred are (1900, 1, 1, 0, 0, 0, 0, 1, -1). 
""" http://docs.python.org/dev/py3k/library/time.html#time.strptime

and "datetime.strptime(date_string, format) is equivalent to datetime(*(time.strptime(date_string, format)[0:6]))." according to datetime module documentation.

Thus, datetime.strptime("", "") returning datetime.datetime(1900, 1, 1, 0, 0) is not an implementation detail and there is no need to compute it in time_strptime.
History
Date User Action Args
2010-04-20 16:02:19Alexander.Belopolskysetrecipients: + Alexander.Belopolsky, guettli, amaury.forgeotdarc, sonderblade, alanvgreen, ajaksu2, josh-sf, tiktuk
2010-04-20 16:02:19Alexander.Belopolskysetmessageid: <1271779339.37.0.603568725323.issue1100942@psf.upfronthosting.co.za>
2010-04-20 16:02:17Alexander.Belopolskylinkissue1100942 messages
2010-04-20 16:02:17Alexander.Belopolskycreate