Author exarkun
Recipients akuchling, exarkun, irmen, loewis
Date 2010-04-05.16:01:48
SpamBayes Score 1.46055e-08
Marked as misclassified No
Message-id <1270483310.18.0.765479731048.issue1103213@psf.upfronthosting.co.za>
In-reply-to
Content
Just a couple comments:

  * If MSG_WAITALL is defined and a signal interrupts recv, will a string shorter than requested will be returned by sock_recvall?
  * Since MSG_WAITALL is already exposed to Python (when the underlying platform provides it), I wonder if this could all be implemented more simply in pure Python.  Can you elaborate on the motivation to use C?

Someone should do another review when there are unit tests.
History
Date User Action Args
2010-04-05 16:01:50exarkunsetrecipients: + exarkun, loewis, akuchling, irmen
2010-04-05 16:01:50exarkunsetmessageid: <1270483310.18.0.765479731048.issue1103213@psf.upfronthosting.co.za>
2010-04-05 16:01:48exarkunlinkissue1103213 messages
2010-04-05 16:01:48exarkuncreate