This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ggenellina
Recipients bogdan.opanchuk, draghuram, ggenellina, kristjan.jonsson
Date 2010-03-24.07:53:42
SpamBayes Score 0.00021050619
Marked as misclassified No
Message-id <1269417223.37.0.816013455876.issue6701@psf.upfronthosting.co.za>
In-reply-to
Content
Just a few comments on the code itself:

    if type_ in self.__dispatch.keys():
should be:
    if type_ in self.__dispatch:

Previously, error reporting of recursive data stated the type of the offending value; with this patch, this hint is lost (see _add_memo)

Caching of bound methods in local variables is a common optimization (dump=self._dump); why did you remove it everywhere?

Why Marshaller.dispatch was renamed to __dispatch but Unmarshaller.dispatch stays the same? (btw, why the double underscore?)
History
Date User Action Args
2010-03-24 07:53:43ggenellinasetrecipients: + ggenellina, kristjan.jonsson, draghuram, bogdan.opanchuk
2010-03-24 07:53:43ggenellinasetmessageid: <1269417223.37.0.816013455876.issue6701@psf.upfronthosting.co.za>
2010-03-24 07:53:42ggenellinalinkissue6701 messages
2010-03-24 07:53:42ggenellinacreate