Message101534
> The patch isn't exactly correct: it should ideally retry the unwrap()
> call later, rather than simply ignore the error. But since it's just
> used for testing, it looks sufficient.
Actually unwrap() should already be called.
What the patch does is returning in case of ERROR_WANT_READ/WRITE, and *explicitly avoids to close() the connection when such an event occurs*.
This should grant that another asyncore poll() loop is executed, handle_close() automatically be called again and so unwrap().
As I said in comment #100977 I'm not 100% sure of this since I've not been able to reproduce the issue. I'm just presuming this as I know that asyncore works like this with plain-text sockets.
I'd like to make sure this works as expected even if it's just a test.
If some of the folks able to reproduce this issue could confirm that unwrap() gets called again it would be great. |
|
Date |
User |
Action |
Args |
2010-03-22 21:14:35 | giampaolo.rodola | set | recipients:
+ giampaolo.rodola, janssen, pitrou, vstinner, Arfrever, flox |
2010-03-22 21:14:35 | giampaolo.rodola | set | messageid: <1269292475.68.0.932843030637.issue8108@psf.upfronthosting.co.za> |
2010-03-22 21:14:33 | giampaolo.rodola | link | issue8108 messages |
2010-03-22 21:14:33 | giampaolo.rodola | create | |
|