This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rpetrov
Recipients jcea, loewis, movement, pitrou, rpetrov, sandberg
Date 2010-03-15.22:13:11
SpamBayes Score 1.8075789e-06
Marked as misclassified No
Message-id <4B9EB0F3.5040702@roumenpetrov.info>
In-reply-to <1268662773.0.0.0857682162397.issue3928@psf.upfronthosting.co.za>
Content
Jesús Cea Avión wrote:
>
> Jesús Cea Avión<jcea@jcea.es>  added the comment:
>
> I just did the minimal change. I don't know if removing "defined(HAVE_MAKEDEV)" is safe.

The python build system is full with minimal changes and result is a big 
mess. Did you found which revision add ".. defined(HAVE_MAKEDEV)" in 
posix*.c ?

> "HAVE_DEVICE_MACROS" is defined if "configure" finds "makedev()" macro.

And what is result on you platform ?

> Clarify your comment about configure.in changes being wrong.

Usually just adding #include <xxxx> will break test on platforms where 
xxxx is missing.

The correct implementation will depend from above.

Cases:
1) platform is no longer supported - it is save to remove test case from 
configure and defined(HAVE_MAKEDEV) from posixmodule.c

2) HAVE_DEVICE_MACROS is defined for you . Then check how is written 
test for HAVE_DEVICE_MACROS and make test for makedev similar.

Roumen
History
Date User Action Args
2010-03-15 22:13:15rpetrovsetrecipients: + rpetrov, loewis, jcea, pitrou, movement, sandberg
2010-03-15 22:13:12rpetrovlinkissue3928 messages
2010-03-15 22:13:11rpetrovcreate