Author r.david.murray
Recipients Joaquin.Cuenca.Abela, athomas, esam, r.david.murray
Date 2010-03-04.18:01:59
SpamBayes Score 8.45461e-06
Marked as misclassified No
Message-id <1267725721.8.0.309780243152.issue7143@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for working on this.

For the most part your patch looks fine.  Two comments: (1) it concerns me that by co-opting the existing test, we are no longer testing that decoding does not introduce a spurious newline :).  (2) I think we should add a comment in _bdecode that it used to do more and is retained now only for backward compatibility.

I don't particularly like proliferating test files, and I plan to fix that in email6, but for now I think you should just add a new test file based on msg_10, and a test that uses it.
History
Date User Action Args
2010-03-04 18:02:01r.david.murraysetrecipients: + r.david.murray, athomas, esam, Joaquin.Cuenca.Abela
2010-03-04 18:02:01r.david.murraysetmessageid: <1267725721.8.0.309780243152.issue7143@psf.upfronthosting.co.za>
2010-03-04 18:01:59r.david.murraylinkissue7143 messages
2010-03-04 18:01:59r.david.murraycreate