Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nntplib.py lacks a test suite #54000

Closed
giampaolo opened this issue Sep 7, 2010 · 3 comments
Closed

nntplib.py lacks a test suite #54000

giampaolo opened this issue Sep 7, 2010 · 3 comments
Assignees
@giampaolo
Labels
tests Tests in the Lib/test dir

Comments

@giampaolo
Copy link
Contributor

BPO 9791
Nosy @pitrou, @giampaolo, @sandrotosi

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/giampaolo'
closed_at = <Date 2010-10-19.23:06:21.226>
created_at = <Date 2010-09-07.18:47:27.135>
labels = ['tests']
title = 'nntplib.py lacks a test suite'
updated_at = <Date 2010-10-19.23:06:21.188>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2010-10-19.23:06:21.188>
actor = 'sandro.tosi'
assignee = 'giampaolo.rodola'
closed = True
closed_date = <Date 2010-10-19.23:06:21.226>
closer = 'sandro.tosi'
components = ['Tests']
creation = <Date 2010-09-07.18:47:27.135>
creator = 'giampaolo.rodola'
dependencies = []
files = []
hgrepos = []
issue_num = 9791
keywords = []
message_count = 3.0
messages = ['115792', '115795', '119175']
nosy_count = 3.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'sandro.tosi']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue9791'
versions = ['Python 3.2']
@giampaolo
Copy link
Contributor Author

A very simple test suite which tests at least basic features and methods should be written.
test_ftplib.py and test_smtplib.py can be taken as an example.
Assigning this to me as a reminder.

@giampaolo giampaolo self-assigned this Sep 7, 2010
@giampaolo giampaolo added the tests Tests in the Lib/test dir label Sep 7, 2010
@pitrou
Copy link
Member

pitrou commented Sep 7, 2010

Actually, I just noticed there's some beginnings of a test file in bpo-9360.

@sandrotosi
Copy link
Contributor

Hello, in r85111 Antoine revamped nntplib modules, making it compatible with Python 3, improving its documentation and also adding a test suite. I'm marking this bug as closed/accepted; Giampaolo, if you feel you still want to work on the test suite (I admit I didn't check the coverage), please reopen it (or log a new one).

Regards,
Sandro

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giampaolo giampaolo

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sandrotosi @giampaolo @pitrou