Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetBSD curses KEY_* constants #53876

Closed
bgreen mannequin opened this issue Aug 24, 2010 · 4 comments
Closed

NetBSD curses KEY_* constants #53876

bgreen mannequin opened this issue Aug 24, 2010 · 4 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@bgreen
Copy link
Mannequin

bgreen mannequin commented Aug 24, 2010

BPO 9667
Nosy @gpshead, @bitdancer, @serhiy-storchaka
Superseder
  • bpo-31891: Make curses compiling on NetBSD 7.1 and tests passing
    		•
    Files
  • _cursesmodule.c.diff: patch from bgreen against 2.7.1
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-11-01.18:16:08.957>
created_at = <Date 2010-08-24.10:15:13.116>
labels = ['type-bug', 'library']
title = 'NetBSD curses KEY_* constants'
updated_at = <Date 2017-11-01.18:16:08.955>
user = 'https://bugs.python.org/bgreen'

    bugs.python.org fields:

    activity = <Date 2017-11-01.18:16:08.955>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2017-11-01.18:16:08.957>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2010-08-24.10:15:13.116>
creator = 'bgreen'
dependencies = []
files = ['21215']
hgrepos = []
issue_num = 9667
keywords = ['patch']
message_count = 4.0
messages = ['114774', '130941', '136052', '305389']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'r.david.murray', 'bgreen', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = '31891'
type = 'behavior'
url = 'https://bugs.python.org/issue9667'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
    @bgreen
    Copy link
    Mannequin Author

    bgreen mannequin commented Aug 24, 2010

    _cursesmodule.c provides a list of constants, prefixed with KEY_, corresponding to special keys (KEY_DOWN, KEY_LEFT, KEY_BACKSPACE, etc.). A portion of the function init_curses, which implements these, is #defined out on NetBSD (at line 2860 in Python 2.7). PyCurses_KeyName, which seems related (line 2111) is also not compiled on NetBSD. This is presumably because NetBSD's libcurses doesn't provide this functionality.

    These functions work when _cursesmodule.c is linked to ncurses rather than BSD curses. Could the preprocessor directives be changed to omit these functions only if the platform is NetBSD AND ncurses is not being used?

    @bgreen bgreen mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Aug 24, 2010
    @bitdancer
    Copy link
    Member

    I don't think we have any committers who run NetBDS. Can you attach your patch here? I take it the other NetBSD checks are still required?

    @gpshead gpshead self-assigned this Mar 15, 2011
    @gpshead
    Copy link
    Member

    gpshead commented May 15, 2011

    unassigning, i don't have time to tackle netbsd issues right now.

    @gpshead gpshead removed their assignment May 15, 2011
    @serhiy-storchaka
    Copy link
    Member

    Currently the default curses library on NetBSD provides all guarded functions. All these guards no longer needed. And they were removed in bpo-31891.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @bitdancer @serhiy-storchaka