Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_urllib2_localnet fails on OS X 10.3 #53777

Closed
ned-deily opened this issue Aug 11, 2010 · 6 comments
Closed

test_urllib2_localnet fails on OS X 10.3 #53777

ned-deily opened this issue Aug 11, 2010 · 6 comments
Assignees
@ronaldoussoren
Labels
OS-mac

Comments

@ned-deily
Copy link
Member

BPO 9568
Nosy @warsaw, @ronaldoussoren, @ned-deily
Files
  • issue-proxy-10-3-27-26.txt
  • issue-proxy-10-3-py3k-31.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ronaldoussoren'
closed_at = <Date 2010-09-28.14:44:13.573>
created_at = <Date 2010-08-11.08:11:34.756>
labels = ['OS-mac']
title = 'test_urllib2_localnet fails on OS X 10.3'
updated_at = <Date 2010-09-28.14:44:13.572>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2010-09-28.14:44:13.572>
actor = 'ronaldoussoren'
assignee = 'ronaldoussoren'
closed = True
closed_date = <Date 2010-09-28.14:44:13.573>
closer = 'ronaldoussoren'
components = ['macOS']
creation = <Date 2010-08-11.08:11:34.756>
creator = 'ned.deily'
dependencies = []
files = ['18475', '18476']
hgrepos = []
issue_num = 9568
keywords = []
message_count = 6.0
messages = ['113592', '113594', '113858', '114068', '114076', '117526']
nosy_count = 3.0
nosy_names = ['barry', 'ronaldoussoren', 'ned.deily']
pr_nums = []
priority = 'high'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue9568'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']
    @ned-deily
    Copy link
    Member Author

    bpo-8455 documents a problem which resulted in test_urllib2_libnet failing on OS X with "Connection refused" errors. r82150, r82280, r82281, and r82282 eliminated the test failures for all active branches when running on OS X 10.4 through 10.6. However, the fixes overlooked a different code path which is only used on OS X 10.3. The attached one-line patches for 2.6/2.7 and for py3k/3.1 correct that problem for 10.3 as well.

    Since the patch is low-risk and corrects a failing test case, I recommend that it be applied for the 2.6.6 release.

    @ronaldoussoren
    Copy link
    Contributor

    Barry: I agree with Ned that this is low-risk patch.

    The patch changes a default return value in a code-path that is used on OSX 10.3 to make it the same as the default value on the code-path for other OSX releases.

    I'm therefore +1 on applying this for 2.6.6, but won't apply without explicit permission to do so.

    @warsaw
    Copy link
    Member

    warsaw commented Aug 14, 2010

    Thanks guys. I'll allow this in for 2.6.6 if you can commit it before Sunday 8/15. I'd like the buildbots to have plenty of time to turn green before schedule release on Monday. Please include a NEWS item and close this issue once it's been committed.

    @warsaw
    Copy link
    Member

    warsaw commented Aug 16, 2010

    r84103 in release26-maint

    I will let Ronald commit to the other branches. I did this one due to the timing of 2.6.6 rc 2. Bumping status away from release blocker.

    @ned-deily
    Copy link
    Member Author

    Committed fix verified on 2.6: test_urllib2_localnet no longer fails on 10.3.

    @ronaldoussoren
    Copy link
    Contributor

    Applied the patch in r85062 (3.2), r85063 (3.1), r85064 (2.7)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ronaldoussoren ronaldoussoren

    Labels
    OS-mac
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @warsaw @ronaldoussoren @ned-deily