Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulldom doesn't provide END_DOCUMENT or COMMENT nodes. #53617

Open
marksmith mannequin opened this issue Jul 24, 2010 · 3 comments
Open

pulldom doesn't provide END_DOCUMENT or COMMENT nodes. #53617

marksmith mannequin opened this issue Jul 24, 2010 · 3 comments
Labels
topic-XML type-bug An unexpected behavior, bug, or error

Comments

@marksmith
Copy link
Mannequin

marksmith mannequin commented Jul 24, 2010

BPO 9371
Nosy @scoder, @merwok
PRs
  • bpo-35018: Sax parser provides no user access to lexical handlers. #10328
  • Files
  • test_pulldom.py: A TestCase to demonstrate this issue.
  • pulldom_enddoc_event_fix.patch: bugfix for ENDDOCUMENT event
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2010-07-24.13:01:50.678>
    labels = ['expert-XML', 'type-bug']
    title = "pulldom doesn't provide END_DOCUMENT or COMMENT nodes."
    updated_at = <Date 2019-05-30.20:00:25.245>
    user = 'https://bugs.python.org/marksmith'

    bugs.python.org fields:

    activity = <Date 2019-05-30.20:00:25.245>
    actor = 'cheryl.sabella'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['XML']
    creation = <Date 2010-07-24.13:01:50.678>
    creator = 'mark.smith'
    dependencies = []
    files = ['18183', '24787']
    hgrepos = []
    issue_num = 9371
    keywords = ['patch']
    message_count = 3.0
    messages = ['111474', '111486', '155409']
    nosy_count = 4.0
    nosy_names = ['scoder', 'eric.araujo', 'mark.smith', 'flomm']
    pr_nums = ['10328']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue9371'
    versions = ['Python 3.2']

    @marksmith
    Copy link
    Mannequin Author

    marksmith mannequin commented Jul 24, 2010

    I've been developing unit tests to increase the code coverage for pulldom, and have discovered that comments and end_document do not appear to result in events being obtained from the DOMEventStream.

    I've attached a failing TestCase to demonstrate this.

    @marksmith marksmith mannequin added topic-XML type-bug An unexpected behavior, bug, or error labels Jul 24, 2010
    @merwok
    Copy link
    Member

    merwok commented Jul 24, 2010

    I tried looking at the doc to see if this was by design, and well, pulldom docs :) So I looked at the code, same thing, and finally read the commit history. It appears that pulldom is supposed to be DOM-compliant, so go ahead in adding unit tests for that and fixing it.

    @flomm
    Copy link
    Mannequin

    flomm mannequin commented Mar 11, 2012

    I found the bug for the end_document event and fixed it. But I couldn't figure out why the PullDOM class did not have comment-events.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-XML type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant