Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poplib should support SSL contexts #53053

Closed
pitrou opened this issue May 24, 2010 · 4 comments
Closed

poplib should support SSL contexts #53053

pitrou opened this issue May 24, 2010 · 4 comments
Assignees
@giampaolo
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented May 24, 2010

BPO 8807
Nosy @pitrou, @giampaolo
Files
  • poplib.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/giampaolo'
closed_at = <Date 2010-08-17.16:11:12.068>
created_at = <Date 2010-05-24.16:10:52.339>
labels = ['type-feature', 'library']
title = 'poplib should support SSL contexts'
updated_at = <Date 2010-08-17.16:11:12.067>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2010-08-17.16:11:12.067>
actor = 'giampaolo.rodola'
assignee = 'giampaolo.rodola'
closed = True
closed_date = <Date 2010-08-17.16:11:12.068>
closer = 'giampaolo.rodola'
components = ['Library (Lib)']
creation = <Date 2010-05-24.16:10:52.339>
creator = 'pitrou'
dependencies = []
files = ['17469']
hgrepos = []
issue_num = 8807
keywords = ['patch']
message_count = 4.0
messages = ['106367', '106574', '106777', '114132']
nosy_count = 3.0
nosy_names = ['janssen', 'pitrou', 'giampaolo.rodola']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue8807'
versions = ['Python 3.2']
    @pitrou
    Copy link
    Member Author

    pitrou commented May 24, 2010

    3.2 introduces SSL contexts, which allow bundling SSL configuration options, certificates and private keys into a single (potentially long-lived) structure.
    http://docs.python.org/dev/py3k/library/ssl.html#ssl.SSLContext

    The POP3_SSL constructor should allow passing an SSL context object instead of a key/cert pair.

    @pitrou pitrou added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 24, 2010
    @giampaolo
    Copy link
    Contributor

    Patch in attachment.
    The same approach adopted for ftplib (bpo-8806) was used.

    @pitrou
    Copy link
    Member Author

    pitrou commented May 30, 2010

    There's the problem mentioned by Ezio: it breaks compatibility if someone passed a timeout to POP3_SSL by position (rather than by name).

    @giampaolo giampaolo self-assigned this Aug 17, 2010
    @giampaolo
    Copy link
    Contributor

    Committed in r84144 including "context" being the last constructor argument.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @giampaolo giampaolo

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @giampaolo @pitrou