New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random stack corruption from socketmodule.c #39819
Comments
THE PROBLEM: The implementation of the socket_object.settimeout() method This took me ages to track down! It happened with a massively Demonstration script appended. THE SOLUTION: The solution is to use poll() and to favour poll() even if select() Not so the other way round (only some systems of historical interest And if select() is your only choice, then check for FD_SETSIZE before [ A PATCH, A PATCH? Well, the check for FD_SETSIZE is left as an exercise for the reader. :-) But yes, I can do a 'real' patch with poll() [and even one with the So, dear Python core developers: Please discuss this and tell me, Thank you for your time! |
Logged In: YES I have created a patch to make socketmodule use poll() when (I'm not allowed to attach patches to this bug item.) |
Logged In: YES Thanks! Committed revision 42253. |
Logged In: YES Unfortunately r42253 breaks things on win32 (at least on my By default FD_SETSIZE is 64 (winsock.h, winsock2.h). Even if What is a reasonable value for FD_SETSIZE then? 1024? Are there plans to "elaborate" on the last fix? |
Logged In: YES The patch that has been applied has no relevance to Windows |
Logged In: YES Martin has fixed my Window's breakage by only checking for |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: