Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional keyword unicode args not handled correctly #39662

Closed
rupole mannequin opened this issue Dec 4, 2003 · 5 comments
Closed

Optional keyword unicode args not handled correctly #39662

rupole mannequin opened this issue Dec 4, 2003 · 5 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@rupole
Copy link
Mannequin

rupole mannequin commented Dec 4, 2003

BPO 853890
Nosy @birkenfeld
Files
  • getargs.patch: patch for getargs.c
  • skipitem.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2005-06-01.18:24:46.000>
created_at = <Date 2003-12-04.08:05:17.000>
labels = ['interpreter-core']
title = 'Optional keyword unicode args not handled correctly'
updated_at = <Date 2005-06-01.18:24:46.000>
user = 'https://bugs.python.org/rupole'

    bugs.python.org fields:

    activity = <Date 2005-06-01.18:24:46.000>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2003-12-04.08:05:17.000>
creator = 'rupole'
dependencies = []
files = ['5728', '5729']
hgrepos = []
issue_num = 853890
keywords = ['patch']
message_count = 5.0
messages = ['45013', '45014', '45015', '45016', '45017']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'mdr0', 'mdehoon', 'rupole']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue853890'
versions = []
    @rupole
    Copy link
    Mannequin Author

    rupole mannequin commented Dec 4, 2003

    Added a case for 'u' in skipitem in getargs.c

    @rupole rupole mannequin closed this as completed Dec 4, 2003
    @rupole rupole mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 4, 2003
    @rupole rupole mannequin closed this as completed Dec 4, 2003
    @rupole rupole mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 4, 2003
    @mdr0
    Copy link
    Mannequin

    mdr0 mannequin commented Jul 6, 2004

    Logged In: YES
    user_id=994239

    skipitem() is actually missing code for a number of other
    format units, in addition to "u" and "u#". See patch 985713
    for more information.

    @mdehoon
    Copy link
    Mannequin

    mdehoon mannequin commented Mar 27, 2005

    Logged In: YES
    user_id=488897

    As mdr0 mentioned, skipitem misses code for several formats.
    This patch solves one, patch 985713 solves another one.
    Could you make a patch that solves all missing formats in
    skipitem? You can look at the convertsimple function to find
    all formats.

    @rupole
    Copy link
    Mannequin Author

    rupole mannequin commented Mar 28, 2005

    Logged In: YES
    user_id=771074

    After taking another look at this, all the arguments it
    processes are pointers. Since they're not actually changed
    by this function, they can all be treated as void *, eliminating
    the case stmt altogether and effectively future-proofing the
    function. With as little code as is left, and since it's only
    called from one place, inlining it might be feasible.

    This leaves out validation of the format char, but I'd say it's up
    to whoever constructs the argument format to make sure it
    works correctly when you pass in a matching arg.

    @birkenfeld
    Copy link
    Member

    Logged In: YES
    user_id=1188172

    Closing; subsumed by patch bpo-1212928.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @birkenfeld