Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot: test_ttk_guionly failures (test_traversal, test_tab_identifiers, test_identify, test_heading_callback) #52692

Closed
vstinner opened this issue Apr 18, 2010 · 19 comments
Labels
OS-mac tests Tests in the Lib/test dir topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

BPO 8445
Nosy @db3l, @ronaldoussoren, @pitrou, @vstinner, @ned-deily, @florentx
Files
  • issue8445.diff
  • ttk3k.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-04-12.23:02:40.569>
    created_at = <Date 2010-04-18.21:29:11.122>
    labels = ['OS-mac', 'tests', 'type-bug', 'expert-tkinter']
    title = 'buildbot: test_ttk_guionly failures (test_traversal, test_tab_identifiers, test_identify, test_heading_callback)'
    updated_at = <Date 2011-04-12.23:02:40.567>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2011-04-12.23:02:40.567>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-04-12.23:02:40.569>
    closer = 'vstinner'
    components = ['macOS', 'Tests', 'Tkinter']
    creation = <Date 2010-04-18.21:29:11.122>
    creator = 'vstinner'
    dependencies = []
    files = ['19019', '19024']
    hgrepos = []
    issue_num = 8445
    keywords = ['patch', 'buildbot']
    message_count = 19.0
    messages = ['103534', '103538', '116213', '116527', '117399', '117406', '117411', '117412', '117415', '117421', '117422', '117423', '117424', '117994', '118239', '118240', '118262', '118273', '133615']
    nosy_count = 10.0
    nosy_names = ['ixokai', 'db3l', 'ronaldoussoren', 'janssen', 'pitrou', 'vstinner', 'donmez', 'gpolo', 'ned.deily', 'flox']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue8445'
    versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

    @vstinner
    Copy link
    Member Author

    http://www.python.org/dev/buildbot/builders/x86 Tiger trunk/builds/15/steps/test/logs/stdio

    test test_ttk_guionly failed -- multiple errors occurred; run in verbose mode for details
    Re-running test 'test_ttk_guionly' in verbose mode
    test_horizontal_range (test_ttk.test_extensions.LabeledScaleTest) ... ok
    test_initialization (test_ttk.test_extensions.LabeledScaleTest) ... ok
    test_resize (test_ttk.test_extensions.LabeledScaleTest) ... ok
    test_variable_change (test_ttk.test_extensions.LabeledScaleTest) ... ok
    test_widget_destroy (test_ttk.test_extensions.LabeledScaleTest) ... ok
    test_initialization (test_ttk.test_extensions.OptionMenuTest) ... ok
    test_menu (test_ttk.test_extensions.OptionMenuTest) ... ok
    test_widget_destroy (test_ttk.test_extensions.OptionMenuTest) ... ok
    test_configure (test_ttk.test_style.StyleTest) ... ok
    test_layout (test_ttk.test_style.StyleTest) ... ok
    test_lookup (test_ttk.test_style.StyleTest) ... ok
    test_map (test_ttk.test_style.StyleTest) ... ok
    test_theme_use (test_ttk.test_style.StyleTest) ... ok
    test_identify (test_ttk.test_widgets.WidgetTest) ... FAIL
    test_widget_state (test_ttk.test_widgets.WidgetTest) ... ok
    test_invoke (test_ttk.test_widgets.ButtonTest) ... ok
    test_invoke (test_ttk.test_widgets.CheckbuttonTest) ... ok
    test_invoke (test_ttk.test_widgets.RadiobuttonTest) ... ok
    test_postcommand (test_ttk.test_widgets.ComboboxTest) ... ok
    test_values (test_ttk.test_widgets.ComboboxTest) ... ok
    test_virtual_event (test_ttk.test_widgets.ComboboxTest) ... ok
    test_bbox (test_ttk.test_widgets.EntryTest) ... ok
    test_identify (test_ttk.test_widgets.EntryTest) ... ok
    test_revalidation (test_ttk.test_widgets.EntryTest) ... ok
    test_validation (test_ttk.test_widgets.EntryTest) ... ok
    test_validation_options (test_ttk.test_widgets.EntryTest) ... ok
    test_add (test_ttk.test_widgets.PanedwindowTest) ... ok
    test_forget (test_ttk.test_widgets.PanedwindowTest) ... ok
    test_insert (test_ttk.test_widgets.PanedwindowTest) ... ok
    test_pane (test_ttk.test_widgets.PanedwindowTest) ... ok
    test_sashpos (test_ttk.test_widgets.PanedwindowTest) ... ok
    test_custom_event (test_ttk.test_widgets.ScaleTest) ... ok
    test_get (test_ttk.test_widgets.ScaleTest) ... ok
    test_set (test_ttk.test_widgets.ScaleTest) ... ok
    test_add_and_hidden (test_ttk.test_widgets.NotebookTest) ... ok
    test_forget (test_ttk.test_widgets.NotebookTest) ... ok
    test_index (test_ttk.test_widgets.NotebookTest) ... ok
    test_insert (test_ttk.test_widgets.NotebookTest) ... ok
    test_select (test_ttk.test_widgets.NotebookTest) ... ok
    test_tab (test_ttk.test_widgets.NotebookTest) ... ok
    test_tab_identifiers (test_ttk.test_widgets.NotebookTest) ... ERROR
    test_tabs (test_ttk.test_widgets.NotebookTest) ... ok
    test_traversal (test_ttk.test_widgets.NotebookTest) ... FAIL
    test_bbox (test_ttk.test_widgets.TreeviewTest) ... ok
    test_children (test_ttk.test_widgets.TreeviewTest) ... ok
    test_column (test_ttk.test_widgets.TreeviewTest) ... ok
    test_delete (test_ttk.test_widgets.TreeviewTest) ... ok
    test_detach_reattach (test_ttk.test_widgets.TreeviewTest) ... ok
    test_exists (test_ttk.test_widgets.TreeviewTest) ... ok
    test_focus (test_ttk.test_widgets.TreeviewTest) ... ok
    test_heading (test_ttk.test_widgets.TreeviewTest) ... ok
    test_heading_callback (test_ttk.test_widgets.TreeviewTest) ... FAIL
    test_index (test_ttk.test_widgets.TreeviewTest) ... ok
    test_insert_item (test_ttk.test_widgets.TreeviewTest) ... ok
    test_set (test_ttk.test_widgets.TreeviewTest) ... ok
    test_tag_bind (test_ttk.test_widgets.TreeviewTest) ... ok
    test_tag_configure (test_ttk.test_widgets.TreeviewTest) ... ok

    ======================================================================
    ERROR: test_tab_identifiers (test_ttk.test_widgets.NotebookTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 560, in test_tab_identifiers
        self.assertEqual(self.nb.tab('@5,5'), self.nb.tab('current'))
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/ttk.py", line 922, in tab
        return _val_or_dict(kw, self.tk.call, self._w, "tab", tab_id)
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/ttk.py", line 318, in _val_or_dict
        res = func(*(args + options))
    TclError: tab '@5,5' not found

    ======================================================================
    FAIL: test_identify (test_ttk.test_widgets.WidgetTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 27, in test_identify
        self.assertEqual(self.widget.identify(5, 5), "label")
    AssertionError: 'Button.button' != 'label'

    ======================================================================
    FAIL: test_traversal (test_ttk.test_widgets.NotebookTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 721, in test_traversal
        self.assertEqual(self.nb.select(), str(self.child1))
    AssertionError: '.33941048' != '.33942584'

    ======================================================================
    FAIL: test_heading_callback (test_ttk.test_widgets.TreeviewTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/trunk.bolen-tiger/build/Lib/lib-tk/test/test_ttk/test_widgets.py", line 941, in test_heading_callback
        self.fail("The command associated to the treeview heading wasn't "
    AssertionError: The command associated to the treeview heading wasn't invoked.

    Ran 57 tests in 0.361s

    @vstinner
    Copy link
    Member Author

    http://www.python.org/dev/buildbot/builders/x86 FreeBSD 3.1/builds/149/steps/test/logs/stdio

    ======================================================================
    FAIL: test_traversal (tkinter.test.test_ttk.test_widgets.NotebookTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/usr/home/db3l/buildarea/3.1.bolen-freebsd/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 708, in test_traversal
        self.assertEqual(self.nb.select(), str(self.child2))
    AssertionError: '.219316556' != '.219317508'

    Ran 57 tests in 13.798s

    FAILED (failures=1)
    test test_ttk_guionly failed -- Traceback (most recent call last):
      File "/usr/home/db3l/buildarea/3.1.bolen-freebsd/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 708, in test_traversal
        self.assertEqual(self.nb.select(), str(self.child2))
    AssertionError: '.219316556' != '.219317508'

    @vstinner vstinner added tests Tests in the Lib/test dir topic-tkinter labels Apr 18, 2010
    @vstinner vstinner changed the title buildbot: test_ttk_guionly failures buildbot: test_ttk_guionly failures (test_traversal, test_tab_identifiers, test_identify, test_heading_callback) Apr 18, 2010
    @florentx florentx mannequin added the OS-mac label Sep 11, 2010
    @florentx florentx mannequin assigned ronaldoussoren Sep 11, 2010
    @florentx florentx mannequin added the type-bug An unexpected behavior, bug, or error label Sep 11, 2010
    @donmez
    Copy link
    Mannequin

    donmez mannequin commented Sep 12, 2010

    Also reproduced on Snow Leopard.

    @ronaldoussoren
    Copy link
    Contributor

    Unassigning because the issue affects more than just OSX and I'm not a Tkinter expert.

    @ronaldoussoren ronaldoussoren removed their assignment Sep 16, 2010
    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Sep 26, 2010

    Hi there,

    I believe I've fixed most of these errors. But I couldn't replicate the last error on the first message, so I guessed what could be the problem.

    Could you try the patch and see how it works for you ?

    (Thanks for the nosy addition, I rarely check for bugs as you may know).

    @donmez
    Copy link
    Mannequin

    donmez mannequin commented Sep 26, 2010

    With Guilherme's patch;

    We are down to 1 error but thats a new errror;

    test test_ttk_guionly failed -- Traceback (most recent call last):
      File "/Users/cartman/Sources/py3k/Lib/tkinter/test/test_ttk/test_widgets.py", line 28, in test_identify
        self.widget.winfo_height() / 2), "label")
      File "/Users/cartman/Sources/py3k/Lib/tkinter/ttk.py", line 568, in identify
        return self.tk.call(self._w, "identify", x, y)
    _tkinter.TclError: expected integer but got "30.5"

    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Sep 26, 2010

    > We are down to 1 error but thats a new errror;
    >
    >
    > test test_ttk_guionly failed -- Traceback (most recent call last):
    >  File "/Users/cartman/Sources/py3k/Lib/tkinter/test/test_ttk/test_widgets.py", line 28, in test_identify
    >    self.widget.winfo_height() / 2), "label")
    >  File "/Users/cartman/Sources/py3k/Lib/tkinter/ttk.py", line 568, in identify
    >    return self.tk.call(self._w, "identify", x, y)
    > _tkinter.TclError: expected integer but got "30.5"
    >

    Just convert to integer the results from winfo and you should be fine.

    @gpolo
    Copy link
    Mannequin

    gpolo mannequin commented Sep 26, 2010

    You should convert the whole expressions actually, but that is because the patch wasn't done for py3k.

    @pitrou
    Copy link
    Member

    pitrou commented Sep 26, 2010

    Here is Guilherme's patch converted for py3k.

    @donmez
    Copy link
    Mannequin

    donmez mannequin commented Sep 26, 2010

    Patch fixes the problem for me, please apply. Thanks!

    @pitrou
    Copy link
    Member

    pitrou commented Sep 26, 2010

    Committed in r85018, will watch the buildbots.

    @pitrou
    Copy link
    Member

    pitrou commented Sep 26, 2010

    There's an issue remaining on the buildbots:

    ======================================================================
    FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/tkinter/test/test_ttk/test_widgets.py", line 945, in test_heading_callback
        self.fail("The command associated to the treeview heading wasn't "
    AssertionError: The command associated to the treeview heading wasn't invoked.

    @donmez
    Copy link
    Mannequin

    donmez mannequin commented Sep 26, 2010

    Works for me on Snow Leopard for the record.

    @ned-deily
    Copy link
    Member

    The test_heading_callback failure appears to be another Tk 8.4 vs Tk 8.5 problem. Datapoints: the test fails using the Apple-supplied Tk 8.4 in OS X 10.6 and with a recent ActiveState Aqua Tk 8.4 on OS X 10.5; the test succeeds with the Apple-supplied Tk 8.5 in OS X 10.6.

    @ixokai
    Copy link
    Mannequin

    ixokai mannequin commented Oct 9, 2010

    I'm still getting this error on the release27-maint branch on my Snow Leopard slave, and the bpo-8445.diff fixes it: will this fix be backported?

    I tested bpo-8445.diff and it applies cleanly, and fixes the issue.

    @ixokai
    Copy link
    Mannequin

    ixokai mannequin commented Oct 9, 2010

    BTW, release31-maint appears to have the same issue, its fouling up that build on my slave too. I tried applying the ttk3k.patch but it didn't apply cleanly, and I'm completely ignorant of TK so can't really figure out what's different between the 3.1->3.2 version to try to adjust the fix and test it out.

    Then again I'm not sure if there's still going to be test-fixes applied to 3.1. So its possible you can just ignore this comment :)

    @pitrou
    Copy link
    Member

    pitrou commented Oct 9, 2010

    I backported the patch to 2.7 (r85335) and to 3.1 (r85338). Hopefully things will be ok now.

    @ixokai
    Copy link
    Mannequin

    ixokai mannequin commented Oct 9, 2010

    For the record, everything (2.7, 3.1, and 3.x) runs this test successfully now. :)

    @vstinner
    Copy link
    Member Author

    I don't understand why this issue is still open, so let's close it.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS-mac tests Tests in the Lib/test dir topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants