Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popen2 work, fixes bugs 768649 and 761888 #39349

Closed
gaul mannequin opened this issue Oct 1, 2003 · 4 comments
Closed

popen2 work, fixes bugs 768649 and 761888 #39349

gaul mannequin opened this issue Oct 1, 2003 · 4 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@gaul
Copy link
Mannequin

gaul mannequin commented Oct 1, 2003

BPO 816059
Nosy @loewis, @gaul, @amauryfa, @devdanzin
Dependencies
  • bpo-761888: popen2.Popen3 and popen2.Popen4 leaks filedescriptors
  • Files
  • popen2.diff: popen2 work
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/loewis'
    closed_at = <Date 2010-08-18.16:39:46.405>
    created_at = <Date 2003-10-01.18:48:03.000>
    labels = ['type-bug', 'library']
    title = 'popen2 work, fixes bugs 768649 and 761888'
    updated_at = <Date 2010-08-18.16:39:46.405>
    user = 'https://github.com/gaul'

    bugs.python.org fields:

    activity = <Date 2010-08-18.16:39:46.405>
    actor = 'BreamoreBoy'
    assignee = 'loewis'
    closed = True
    closed_date = <Date 2010-08-18.16:39:46.405>
    closer = 'BreamoreBoy'
    components = ['Library (Lib)']
    creation = <Date 2003-10-01.18:48:03.000>
    creator = 'gaul'
    dependencies = ['761888']
    files = ['5614']
    hgrepos = []
    issue_num = 816059
    keywords = ['patch']
    message_count = 4.0
    messages = ['44725', '81495', '81695', '90331']
    nosy_count = 4.0
    nosy_names = ['loewis', 'gaul', 'amaury.forgeotdarc', 'ajaksu2']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = 'test needed'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue816059'
    versions = ['Python 2.6']

    @gaul
    Copy link
    Mannequin Author

    gaul mannequin commented Oct 1, 2003

    Plug popen2.popen[234] leak (see bug bpo-768649 for
    discussion). Handle os.{pipe,fork} exceptions (see bug
    bpo-761888). Change class variables into instance
    variables, allowing following code to work properly:

    from popen2 import Popen3
    p1 = Popen3('ls')
    p1.fromchild.read()
    Popen3('ls').fromchild.read()
    Popen3('ls').fromchild.read()
    p1.wait()

    Update docstrings to mention popen4 and warn about
    mixing Popen3 objects and threading. Expand on MAX_FD
    comment.

    @gaul gaul mannequin assigned loewis Oct 1, 2003
    @gaul gaul mannequin added the stdlib Python modules in the Lib dir label Oct 1, 2003
    @gaul gaul mannequin assigned loewis Oct 1, 2003
    @gaul gaul mannequin added the stdlib Python modules in the Lib dir label Oct 1, 2003
    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented Feb 9, 2009

    Maybe this is a won't fix, since popen2 in long deprecated?

    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented Feb 12, 2009

    The test code seems to run fine in a debug build of trunk, but the
    linked issues requires a more complex context.

    @devdanzin devdanzin mannequin added type-bug An unexpected behavior, bug, or error labels Feb 12, 2009
    @amauryfa
    Copy link
    Member

    amauryfa commented Jul 9, 2009

    OTOH, the test code runs fine with python 2.4.4, so what is the purpose
    of this patch?

    @BreamoreBoy BreamoreBoy mannequin closed this as completed Aug 18, 2010
    @BreamoreBoy BreamoreBoy mannequin closed this as completed Aug 18, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant