Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for cp858 #52264

Closed
thatch mannequin opened this issue Feb 25, 2010 · 6 comments
Closed

Support for cp858 #52264

thatch mannequin opened this issue Feb 25, 2010 · 6 comments
Assignees
@benjaminp
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@thatch
Copy link
Mannequin

thatch mannequin commented Feb 25, 2010

BPO 8016
Nosy @malemburg, @birkenfeld, @vstinner, @benjaminp, @thatch
Files
  • cp858.diff: Diffs to create cp858.{txt,py} from cp850.{txt,py}
  • cp858.diff: Diffs to create cp858.{txt,py} from cp850.{txt,py} (v2)
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/benjaminp'
closed_at = <Date 2010-05-24.21:29:20.333>
created_at = <Date 2010-02-25.00:17:57.262>
labels = ['type-feature', 'library']
title = 'Support for cp858'
updated_at = <Date 2010-05-24.21:29:20.299>
user = 'https://github.com/thatch'

    bugs.python.org fields:

    activity = <Date 2010-05-24.21:29:20.299>
actor = 'georg.brandl'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2010-05-24.21:29:20.333>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2010-02-25.00:17:57.262>
creator = 'thatch'
dependencies = []
files = ['16366', '17301']
hgrepos = []
issue_num = 8016
keywords = ['patch']
message_count = 6.0
messages = ['100081', '105550', '106299', '106313', '106385', '106395']
nosy_count = 5.0
nosy_names = ['lemburg', 'georg.brandl', 'vstinner', 'benjamin.peterson', 'thatch']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue8016'
versions = ['Python 3.2']
    @thatch
    Copy link
    Mannequin Author

    thatch mannequin commented Feb 25, 2010

    Based on codepage 850, codepage 858 adds support for the euro symbol1. This codepage is used on many thermal receipt printers, such as the Epson TM-T88IV and NCR 7198 as the only way to print a euro. There is no CP858.TXT on the unicode.org ftp, so I've attached the diff of the TXT file to create it from CP850, as well as the diff for cp858.py against cp850.py.

    The codepage is supported by java2 and by iconv3, and it'd be nice if future versions of python could support this natively.

    Let me know if there's a better way to provide a fix.

    @thatch thatch mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Feb 25, 2010
    @thatch
    Copy link
    Mannequin Author

    thatch mannequin commented May 11, 2010

    Uploading corrected diff -- the old one missed a couple of instances of DOTLESS I -> EURO.

    @birkenfeld
    Copy link
    Member

    Benjamin: OK to put this in 2.7?

    @thatch
    Copy link
    Mannequin Author

    thatch mannequin commented May 22, 2010

    I also noticed that libforensics supplies a codec for cp858, if that's helpful to double-check the implementation. http://code.google.com/p/libforensics/source/browse/code/lf/win/codepage/cp858.py

    @benjaminp
    Copy link
    Contributor

    A new codec is quite self-contained, so that's ok.

    @birkenfeld
    Copy link
    Member

    Thanks all, committed in r81499.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @benjaminp benjaminp

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @birkenfeld @benjaminp